On Wed, Dec 06, 2023 at 06:42:44PM -0800, Darrick J. Wong wrote: > #define XFS_DFORK_DPTR(dip) \ > - ((char *)dip + xfs_dinode_size(dip->di_version)) > + ((void *)dip + xfs_dinode_size(dip->di_version)) > #define XFS_DFORK_APTR(dip) \ > (XFS_DFORK_DPTR(dip) + XFS_DFORK_BOFF(dip)) > #define XFS_DFORK_PTR(dip,w) \ > + if (XFS_DFORK_BOFF(dip) >= mp->m_sb.sb_inodesize) > xchk_ino_set_corrupt(sc, ino); This should be a prep patch. Otherwise I'm still a bit worried about the symlink pointing to ? and suspect we need a clear and documented strategy for things that can change data for applications before doing something like that. The rest looks good to me.
