On Mon, Dec 04, 2023 at 02:26:44AM -0500, Kunhai Dai wrote: > It would be more preferable to present xs_try_logspace and > xs_sleep_logspace on the log line. xs_try_logspace and xs_sleep_logspace are AIL tail pushing statistics. They are related to reservation space exhaustion, not journal operations, so they really are located in the correct stats namespace. Regardless of whether they are correctly located, we can't change the layout of this file like this - it forms part of the user kABI. The file format was defined back in June 2000 (early stages of the XFS port to Linux) and so any change to the layout of the file will break every application and script every written that parses it. So while it might be "preferable" to change the order of stats in the file to group them better, we simply cannot do that because it will break userspace. Cheers, -Dave. -- Dave Chinner david@xxxxxxxxxxxxx
