On Mon, Dec 04, 2023 at 06:04:26AM +0100, Christoph Hellwig wrote: > Not sure if I missed it in my first round of review, or if this is new > in this version, but this now generats a warning when asserts are > disabled, given that the lip variable in xlog_recover_process_intents > is only used in asserts. We'll need to remove it and just open code > the dereference in the two asserts that use it. Yeah, that's the last patch, and I forgot to address that warning because the kbuild robot only sends email to my Outlook now. Clearly I'm not doing CONFIG_XFS_DEBUG=n builds on my development box... --D