> +static struct xfs_log_item *
> +xfs_attr_create_done(
> + struct xfs_trans *tp,
> + struct xfs_log_item *intent,
> + unsigned int count)
> {
> - struct xfs_attrd_log_item *attrdp;
> + struct xfs_attri_log_item *attrip;
> + struct xfs_attrd_log_item *attrdp;
>
> - ASSERT(tp != NULL);
> + if (!intent)
> + return NULL;
> +
> + attrip = ATTRI_ITEM(intent);
How can we end up with a NULL intent here? The intent passed in is
always ->dfp_intent and I don't think that can be NULL. No other
implementation of ->create_done checks for it either.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
