On Sun, Dec 03, 2023 at 11:03:13AM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > Each log intent item's ->finish_item call chain inevitably includes some > code to set the dirty flag of the transaction. If there's an associated > log intent done item, it also sets the item's dirty flag and the > transaction's INTENT_DONE flag. This is repeated throughout the > codebase. > > Reduce the LOC by moving all that to xfs_defer_finish_one. Heh, I've started doing this a few time and ran into the attr іnconsistencies every time. With that sorted out this looks nice now: Reviewed-by: Christoph Hellwig <hch@xxxxxx>