On Tue, Nov 28, 2023 at 12:27:03PM -0800, Darrick J. Wong wrote: > While we're at it, dump xattr log items if the recovery fails with > corruption errors like we do for the other intent items. Normally I'd expect this as a split out prep patch. > - error = xfs_xattri_finish_update(attr, done_item); As a follow on cleanup, xfs_xattri_finish_update could now be folded into xfs_attr_finish_item, making the logic a littl simpler to follow. Same for the other items. Otherwise this looks good to me.
