On Mon, Nov 27, 2023 at 09:13:43AM +0100, Christoph Hellwig wrote: > On Mon, Nov 27, 2023 at 01:13:29PM +0530, Ritesh Harjani wrote: > > Christoph Hellwig <hch@xxxxxx> writes: > > > > > Switch to the same argument order as iomap_writepage_map and remove the > > > ifs argument that can be trivially recalculated. > > > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > > --- > > > fs/iomap/buffered-io.c | 11 +++++------ > > > 1 file changed, 5 insertions(+), 6 deletions(-) > > > > Straight forward change. Looks good to me. Please feel free to add - > > Also the subject should be changed now that I'm reading your reply. > I dropped the rename of this function that I had in earlier versions. With that fixed, Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> --D
