On Mon, Nov 27, 2023 at 09:37:15PM -0800, Christoph Hellwig wrote: > On Mon, Nov 27, 2023 at 10:10:24AM -0800, Darrick J. Wong wrote: > > > It might be time to move this code into shared files? > > > > I think Chandan started looking into what it would take to port the log > > code from the kernel into userspace. Then xfs_trans_commit in userspace > > could actually write transactions to the log and write them back > > atomically; and xfs_repair could finally lose the -L switch. > > While that does sound like a really good idea, it's now what I meant > here. I think if we moved the actual defer ops instances out of the > _item.c files into libxfs, I think we could reuse them for the current > way of operating in userspace quite easily with strategic stubs for > some functionality. Oh! You're talking about moving xfs_rmap_update_defer_type and the functions it points to into xfs_rmap.c, then? Hmm. I just moved ->iop_recover into xfs_defer_op_type, let me send an RFC for that. (You and I might have hit critical mass for log item cleanups... ;)) --D
