On Mon, Nov 27, 2023 at 10:27:38AM -0800, Darrick J. Wong wrote: > Hmm. Or I could decode the ondisk field into a stack variable so that > future flags don't have to deal with that: > > compat = be32_to_cpu(h->v2.xmh_compat_flags); > > if (!mdrestore.external_log && (compat & XFS_MD2_COMPAT_EXTERNALLOG)) > fatal("External Log device is required\n"); That looks even better.