On Mon, Nov 27, 2023 at 06:09:33PM -0800, Darrick J. Wong wrote: > > + spin_lock(&mp->m_sb_lock); > > + fsop.resblks = mp->m_resblks; > > + fsop.resblks_avail = mp->m_resblks_avail; > > + spin_unlock(&mp->m_sb_lock); > > Hm. I sorta preferred keeping these details hidden in xfs_fsops.c > rather than scattering them around and lengthening xfs_ioctl.c, but > I think the calling convention cleanup is worthy enough for: If you prefer I can keep a helper to fill in a xfs_fsop_resblks structure under m_sb_lock in fsops.c, but I'm not sure that's worth it.
