On Sun, Nov 26, 2023 at 02:01:24PM +0100, Christoph Hellwig wrote: > Use struct types instead of typedefs so that the header can be included > with pulling in the headers that define the typedefs, and remove the > pointless externs. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Easy review! Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> --D > --- > fs/xfs/xfs_fsops.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fs/xfs/xfs_fsops.h b/fs/xfs/xfs_fsops.h > index 7536f8a92746f6..44457b0a059376 100644 > --- a/fs/xfs/xfs_fsops.h > +++ b/fs/xfs/xfs_fsops.h > @@ -6,12 +6,12 @@ > #ifndef __XFS_FSOPS_H__ > #define __XFS_FSOPS_H__ > > -extern int xfs_growfs_data(struct xfs_mount *mp, struct xfs_growfs_data *in); > -extern int xfs_growfs_log(struct xfs_mount *mp, struct xfs_growfs_log *in); > +int xfs_growfs_data(struct xfs_mount *mp, struct xfs_growfs_data *in); > +int xfs_growfs_log(struct xfs_mount *mp, struct xfs_growfs_log *in); > int xfs_reserve_blocks(struct xfs_mount *mp, uint64_t request); > -extern int xfs_fs_goingdown(xfs_mount_t *mp, uint32_t inflags); > +int xfs_fs_goingdown(struct xfs_mount *mp, uint32_t inflags); > > -extern int xfs_fs_reserve_ag_blocks(struct xfs_mount *mp); > -extern int xfs_fs_unreserve_ag_blocks(struct xfs_mount *mp); > +int xfs_fs_reserve_ag_blocks(struct xfs_mount *mp); > +int xfs_fs_unreserve_ag_blocks(struct xfs_mount *mp); > > #endif /* __XFS_FSOPS_H__ */ > -- > 2.39.2 > >
