On Fri, Nov 24, 2023 at 08:57:57PM -0800, Christoph Hellwig wrote: > On Fri, Nov 24, 2023 at 03:46:54PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > When scrub is trying to iget an inode, ensure that it won't end up > > deadlocked on a cycle in the inode btree by using an empty transaction > > to store all the buffers. > > My only concern here is how I'm suppsed to know when to use the _safe > version or not. For xchk_iget_safe, I'll amend the comment to read: /* * Safe version of (untrusted) xchk_iget that uses an empty transaction to * avoid deadlocking on loops in the inobt. This should only be used in a * scrub or repair setup routine, and only prior to grabbing a transaction. */ and add a comment for xchk_iget that reads: /* * Grab the inode at @inum. The caller must have created a scrub transaction * so that we can confirm the inumber by walking the inobt and not deadlock on * a loop in the inobt. */ > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! --D
