On Thu, Nov 09, 2023 at 06:21:06AM +0100, Christoph Hellwig wrote: > On Wed, Nov 08, 2023 at 01:45:20PM -0800, Darrick J. Wong wrote: > > This has been running on the djcloud for months with no problems. Enjoy! > > Comments and questions are, as always, welcome. > > Isn't the branch all new? > > Anyway, this fixes skipping the tests when not supported, and runs them > fine when supported: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > Tested-by: Christoph Hellwig <hch@xxxxxx> Thanks! > although I wonder a bit if keeping functionality not actually supported > upstream in upstream xfstests is such a good idea. Keeping it in > a development branch for the feature seems more flexible to me. I guess > there is no point doing a forth and back for this one now, but maybe > should be more careful in the future. At the time Zorro proposed merging all the remaining online fsck tests I didn't think review of the kernel patches was going to continue on for years. --D
