On Thu, Nov 09, 2023 at 08:13:19AM -0800, Darrick J. Wong wrote: > In the longer run: whenever the libxfs 6.7 sync hits the list, I'll be > ready to go with a pair of broader patches to fix all the confusing / > incorrect units and variable names in xfs_repair. This ought to get > merged to xfsprogs 6.6. Yes, please! FYI, I've done a prototype of annotation the rxtnumber_t with __nocast in the kernel, and except for the ugliness in casting all the 0 values it actually looks pretty nice. I hope with the extra work Luc promised we can actually annotate our non-byte offset/bno/len fields with it and get real type checking for them.