On Wed, Nov 08, 2023 at 11:20:48AM -0800, Darrick J. Wong wrote: > Correct. The scan_bmapbt query is in units of rtblocks. For > rextsize==1 there's no error here; for rextsize > 2, the > search_rt_dup_extent queries probe well past the end of the rt_ext_tree > structure, so they never find the duplicate extents. > > This /does/ explain why the one time I tried crosslinking rt extents I > was surprised that xfs_repair didn't seem to detect them consistently. > > Hmm, let me go clean all that up in to a TOTALLY UNTESTED patch. This does looks sensible, but I suspect it makes more sense to do this after merging the series to introduce xfs_rtxnum_t and friends in the RT code. I'll cook up a patch to just fix scan_bmapbt for now.