On Tue, Nov 07, 2023 at 11:49:10PM -0800, Christoph Hellwig wrote: > On Tue, Nov 07, 2023 at 11:44:06PM -0800, Darrick J. Wong wrote: > > > So if you make the pretty print mount point a new variable and pass > > > that first this would become say: > > > > > > xfs_scrub -p /home -b /tmp/scrub > > > > > > ad should still be fine. OR am I missing something? > > > > Nope, you're not missing anything. I could have implemented it as > > another CLI switch and gotten the same result. The appearance of > > "/tmp/scrub" in comm is a bit ugly, but I'm not all that invested in > > avoiding that. > > So I'd definitively prefer that. With the existing option remaining > the one it operates on, and the new designating the pretty printing. > > > > But scrub has by definition full access to the fs as it's scrubbing > > > that. But I guess that access is in the kernel code, which we trust > > > more than the user space code? > > > > Yep. Scrub runs with CAP_SYS_RAWIO, but I want to make it at least a > > little harder for people who specialize in weird ld exploits and the > > like. :) > > Yes. It's also good for the other reason you pointed out. LOL, and I even forgot that the original version of this patch actually did it with '-A /tmp/scrub/'. Well, good on the commit message for reminding me of that. So, SERVICE_MODE=1 xfs_scrub -b -M /tmp/scrub/ /home/ it is, then. --D
