On Tue, Oct 17, 2023 at 08:54:23AM -0700, Darrick J. Wong wrote: > * The buffer is returned read and locked. > @@ -59,12 +73,32 @@ xfs_rtbuf_get( > struct xfs_buf **bpp) /* output: buffer for the block */ > { > struct xfs_mount *mp = args->mount; > + struct xfs_buf **cbpp; /* cached block buffer */ > + xfs_fsblock_t *cbp; /* cached block number */ > struct xfs_buf *bp; /* block buffer, result */ > struct xfs_inode *ip; /* bitmap or summary inode */ > struct xfs_bmbt_irec map; > int nmap = 1; > int error; /* error value */ > > + cbpp = issum ? &args->bbuf : &args->sbuf; > + cbp = issum ? &args->bblock : &args->sblock; Now that we have the summary/bitmap buffers in the args structure, it seems like we can also drop the bp argument from xfs_rtbuf_get and just the pointer in the args structue in the callers.