Re: [PATCH 6/8] xfs: use accessor functions for bitmap words

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 17, 2023 at 07:01:01PM -0700, Darrick J. Wong wrote:
> Note that I still need this (and the _infoptr helper) for online repair
> to be able to generate an in-memory replacement of the bitmap and
> summary file and then be able to memcpy the words into the new ondisk
> file.
> 
> That said, I also noticed that the _rtbitmap_[gs]etword and
> _suminfo_{get,add} functions can be static inlines in xfs_rtbitmap.h, so
> I'll put them right after here and the compiler will (hopefully)
> collapse the nested inlines into something fairly compact.
> 
> Ok, I've made all those changes and I'll resend this patchset tomorrow
> after letting it test overnight.

Ok.  We'll also need to do the same for the summary file.  I still offer
to do the full work myself, but I won't have time for that until next
week.  I didn't really have time for this hack either, but I just carved
it off..



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux