On Thu, Oct 12, 2023 at 07:22:18AM +0200, Christoph Hellwig wrote: > On Wed, Oct 11, 2023 at 11:05:42AM -0700, Darrick J. Wong wrote: > > - if (isrt) { > > - uint64_t rtexts = XFS_FSB_TO_B(mp, del->br_blockcount); > > - > > - do_div(rtexts, mp->m_sb.sb_rextsize); > > - xfs_mod_frextents(mp, rtexts); > > - } > > + if (isrt) > > + xfs_mod_frextents(mp, xfs_rtb_to_rtxt(mp, del->br_blockcount)); > > This is losing the XFS_FSB_TO_B conversion. Now that conversion is > bogus and doesn't match the rest of the code, and only the fact that > we don't currently support delalloc on the RT device has saved our > ass since fa5c836ca8e. Maybe split this into a little prep patch with > the a fixes tag? Done. --D