On Thu, Oct 12, 2023 at 06:51:30AM +0200, Christoph Hellwig wrote: > On Wed, Oct 11, 2023 at 11:02:03AM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > The latest version of the fs geometry structure is v5. > > The commit log and change left me a little confused, having it in > a RT series even more. So I went out and tried to understand it: > > - the fsgeom struct version is used by xfs_fs_geometry > - XFS_FS_GEOM_MAX_STRUCT_VER is not used in the kernel at all, > but libxfs uses it to always query all information in db and > mkfs > - commit 1b6d968de22bffd added the v5 structure, which mostly > contains extra padding, but otherwise just reports the struct > version for now > > So this commit is a no-op for the kernel, and mostly a no-op for > userspace as nothing looks at the new field, but probably useful > for later changes. > > Maybe capture this in the commit log. I've changed the commit message to: xfs: bump max fsgeom struct version The latest version of the fs geometry structure is v5. Bump this constant so that xfs_db and mkfs calls to libxfs_fs_geometry will fill out all the fields. IOWs, this commit is a no-op for the kernel, but will be useful for userspace reporting in later changes. > With that: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thank you! --D
