On Wed, Oct 11, 2023 at 11:01:16AM -0700, Darrick J. Wong wrote: > Hi all, > > The realtime code uses xfs_rtblock_t and xfs_fsblock_t in a lot of > places, and it's very confusing. Clean up all the type usage so that an > xfs_rtblock_t is always a block within the realtime volume, an > xfs_fileoff_t is always a file offset within a realtime metadata file, > and an xfs_rtxnumber_t is always a rt extent within the realtime volume. Question as a follow up: now that we have proper types for all the RT-specific units, what's the point of even keeping xfs_rtblock_t around vs always using xfs_fsblock_t or xfs_rfsblock_t?