Re: [PATCH V2] mkfs: Improve warning when AG size is a multiple of stripe width

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, Sep 18, 2023 at 08:52:49AM +1000, Dave Chinner wrote:
> On Fri, Sep 15, 2023 at 12:22:46PM +0200, cem@xxxxxxxxxx wrote:
> > From: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
> >
> > The current output message prints out a suggestion of an AG size to be
> > used in lieu of the user-defined one.
> > The problem is this suggestion is printed in filesystem blocks, without
> > specifying the suffix to be used.
> >
> > This patch tries to make user's life easier by outputing the option as
> > it should be used by the mkfs, so users can just copy/paste it.
> >
> > Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
> I'm fine with this but, as I said in my previous comment, a man page
> update for agsize is also needed. Something like this:

Thanks, yes I am planning for the manpage update, I just wanted to send the
message fix first before going into the discussion of the manpage, I'll try to
prepare a patch for it today.

> 	agsize=value
> 		This is an alternative to using the agcount
> 		suboption. The value is the desired size of the
> -		allocation group expressed in bytes (usually using
> -		the m or g suffixes).  This value must be a multiple
> -		of the filesystem block size, and must be at  least
> +		allocation group expressed as a multiple of the
> +		filesystem block size.  It must be at  least
> 		16MiB, and no more than 1TiB, and may be
> 		automatically adjusted to properly align with the
> 		stripe geometry.  The agcount and agsize suboptions
> 		are mutually exclusive.

Thanks for the suggestion.


> -Dave.
> --
> Dave Chinner
> david@xxxxxxxxxxxxx

[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]

  Powered by Linux