Re: [PATCH 13/13] ntfs3: free the sbi in ->kill_sb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 9/7/23 06:54, Christian Brauner wrote:
On Thu, Sep 07, 2023 at 06:05:40AM -0700, Guenter Roeck wrote:
On Wed, Aug 09, 2023 at 03:05:45PM -0700, Christoph Hellwig wrote:
As a rule of thumb everything allocated to the fs_context and moved into
the super_block should be freed by ->kill_sb so that the teardown
handling doesn't need to be duplicated between the fill_super error
path and put_super.  Implement an ntfs3-specific kill_sb method to do

Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>

This patch results in:

The appended patch should fix this. Are you able to test it?
I will as well.

Yes, this patch restores the previous behavior (no more backtrace or crash).

Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>

I say "restore previous behavior" because my simple "recursive copy; partially
remove copied files" test still fails. That problem apparently existed since
ntfs3 has been introduced (I see it as far back as v5.15).


[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]

  Powered by Linux