Re: [PATCH 1/2] xfs: allow inode inactivation during a ro mount log recovery

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Tue, Aug 29, 2023 at 04:09:29PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
> In the next patch, we're going to prohibit log recovery if the primary
> superblock contains an unrecognized rocompat feature bit even on
> readonly mounts.  This requires removing all the code in the log
> mounting process that temporarily disables the readonly state.
> Unfortunately, inode inactivation disables itself on readonly mounts.
> Clearing the iunlinked lists after log recovery needs inactivation to
> run to free the unreferenced inodes, which (AFAICT) is the only reason
> why log mounting plays games with the readonly state in the first place.
> Therefore, change the inactivation predicates to allow inactivation
> during log recovery of a readonly mount.
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_inode.c |   14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]

  Powered by Linux