On Wed, Aug 16, 2023 at 06:15:22PM -0700, Luis Chamberlain wrote: > On Wed, Aug 16, 2023 at 05:33:45PM -0700, Darrick J. Wong wrote: > > However, I defined the testing lead (quoting from above): > > > > "**Testing Lead**: This person is responsible for setting the test > > coverage goals of the project, negotiating with developers to decide > > on new tests for new features, and making sure that developers and > > release managers execute on the testing." > > This I thought I could do. Well I certainly invite you to try! :) > > In my mind, that means the testing lead should be reviewing changes > > proposed for tests/xfs/* in fstests by XFS developers to make sure that > > new features are adequately covered; and checking that drive-by > > contributions from others fit well with what's already there. > > This should be included in the description if that's part of the role. > This alone is a task and I'm afraid *that* does require much more time > commitment and experience I don't think I have with XFS yet. And so it > would seem to me a more experience developer on both fstests and XFS > would be required for this. <shrug> I think someone familiar with running a QA organization would know exactly the sorts of things that need testing and how to make a reasonably thorough test plan. They wouldn't necessarily need to know all that much about the xfs codebase per se, though obviously they'd need to be familiar with C and all of its marvelous footguns. (As for testcase review: is that the job of the code reviewer? or the test maintainer? I don't know...) At this time, our testing is so ... uneven ... that "someone who feels totally comfortable with calling bs on obviously inadequate testing and people will listen to" is probably qualification enough. :) > > > And a test lead might do more testing besides fstests. So I can't imagine > > > that I need to check another project to learn about who's in charge of the > > > current project I'm changing. > > > > ...so the testing lead would be the person who you'd talk to directly > > about changes that you want to make. > > I could certainly help try to set a high bar, but to actually ensure > correctness of XFS test patches, I do think that should require a more > seasoned XFS developer and with fstests. <shrug> Maybe we should chat more directly about this? :) I'll look you up in #kdevops (the irc) next week. --D > Luis
