On Wed, Aug 09, 2023 at 06:14:11PM +0200, Christoph Hellwig wrote: > On Wed, Aug 09, 2023 at 08:55:24AM -0700, Darrick J. Wong wrote: > > If I'm following this correctly, putting the superblock flushes the > > bdevs (though it doesn't invalidate the bdev mapping!) and only later > > when we free the xfs_mount do we actually put the buftargs? > > > > That works, though I still think we need to invalidate the bdev > > pagecache for the log and data bdevs. > > Yes, I'll respin it with that. And I'll also add a comment to the > invalidate_bdev calls because it's completely non-obvious as-is. Ok, thanks! You can reuse the commit message if you want. :) --D