On Thu, Jul 27, 2023 at 03:21:08PM -0700, Darrick J. Wong wrote: > Hi all, > > In this series, online repair gains the ability to repair inode records. > To do this, we must repair the ondisk inode and fork information enough > to pass the iget verifiers and hence make the inode igettable again. > Once that's done, we can perform higher level repairs on the incore > inode. The fstests counterpart of this patchset implements stress > testing of repair. > > If you're going to start using this mess, you probably ought to just > pull from my git trees, which are linked below. Most of this makes sense. I think the main thing I'd suggest is documenting the repair decisions being made and how things that get zapped are then rebuilt - it seems like there is a lot of dependency on running other parts of repair after zapping for things to be rebuilt, but it's not immediately clear how the bits are supposed to go together so a little bit of documentation for that would go a long way.... -Dave. -- Dave Chinner david@xxxxxxxxxxxxx
