On Fri, Aug 04, 2023 at 02:34:19PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > If the always_cow debugging flag is enabled, all file writes turn into > copy writes. This dramatically ramps up fragmentation in the filesystem > (intentionally!) so there's no point in complaining about fragmentation. > > I missed these two in the original commit because readahead for md5sum > would create large folios at the start of the file. This resulted in > the fdatatasync after the random writes issuing writeback for the whole > large folio, which reduced file fragmentation to the point where this > test started passing. > > With Ritesh's patchset implementing sub-folio dirty tracking, this test > goes back to failing due to high fragmentation (as it did before large > folios) so we need to mask these off too. > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > --- Good to me, this patch is simple enough and no risk, will be inserted into the release directly tomorrow. Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx> > tests/xfs/180 | 1 + > tests/xfs/208 | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/tests/xfs/180 b/tests/xfs/180 > index cfea2020ce..d2fac03a9e 100755 > --- a/tests/xfs/180 > +++ b/tests/xfs/180 > @@ -23,6 +23,7 @@ _require_scratch_reflink > _require_cp_reflink > _require_xfs_io_command "fiemap" > _require_xfs_io_command "cowextsize" > +_require_no_xfs_always_cow > > echo "Format and mount" > _scratch_mkfs > $seqres.full 2>&1 > diff --git a/tests/xfs/208 b/tests/xfs/208 > index 9a71b74f6f..1e7734b822 100755 > --- a/tests/xfs/208 > +++ b/tests/xfs/208 > @@ -26,6 +26,7 @@ _require_scratch_reflink > _require_cp_reflink > _require_xfs_io_command "fiemap" > _require_xfs_io_command "cowextsize" > +_require_no_xfs_always_cow > > echo "Format and mount" > _scratch_mkfs > $seqres.full 2>&1 >
