On 7/21/23 10:30?AM, Jens Axboe wrote:
> On 7/21/23 10:28?AM, Darrick J. Wong wrote:
>>> diff --git a/include/linux/fs.h b/include/linux/fs.h
>>> index 6867512907d6..60e2b4ecfc4d 100644
>>> --- a/include/linux/fs.h
>>> +++ b/include/linux/fs.h
>>> @@ -338,6 +338,20 @@ enum rw_hint {
>>> #define IOCB_NOIO (1 << 20)
>>> /* can use bio alloc cache */
>>> #define IOCB_ALLOC_CACHE (1 << 21)
>>> +/*
>>> + * IOCB_DIO_CALLER_COMP can be set by the iocb owner, to indicate that the
>>> + * iocb completion can be passed back to the owner for execution from a safe
>>> + * context rather than needing to be punted through a workqueue.If this If this
>>
>> "...through a workqueue. If this flag is set..."
>>
>> Need a space after the period, and delete one of the "If this".
>>
>> With that fixed,
>> Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
>
> Thanks - same ask on the edit. Or let me know if:
>
> a) you're fine with staging this in a separate branch for 6.6, or
> b) you want a v5a/v6 edition posted
>
> Either way is no trouble for me, just wary of spamming...
FWIW, here's the updated branch:
https://git.kernel.dk/cgit/linux/log/?h=xfs-async-dio.5
--
Jens Axboe
