On 7/19/23 10:54?PM, Christoph Hellwig wrote: > On Wed, Jul 19, 2023 at 01:54:14PM -0600, Jens Axboe wrote: >> Whether we have a write back cache and are using FUA or don't have >> a write back cache at all is the same situation. Treat them the same. > > This looks correct, but I think the IOMAP_DIO_WRITE_FUA is rather > misnamed now which could lead to confusion. The comment in It is - should I rename it to IOMAP_DIO_STABLE_WRITE or something like that as part of this change? > __iomap_dio_rw when checking the flag and clearing IOMAP_DIO_NEED_SYNC > also needs a little update to talk about writethrough semantics and > not just FUA now. Will do. -- Jens Axboe
