On Fri, Jul 14, 2023 at 04:46:38PM +0200, Christoph Hellwig wrote: > The change itself looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > But as mentioned in the last thread leaving these out in the UAPI > is a bit dangerous, and at the same time they really shouldn't > be in the uapi. Do you want me to send an incremental patch for > that? Yes please. :) FWIW I tried removing the attrlist ioctl structs, but I couldn't find anywhere else in the kernel uapi headers that defines them so that the ioctl code can actually format the buffer. --D
