On Fri, Jul 14, 2023 at 02:26:08PM +0800, liubin001@xxxxxxxxxx wrote: > xfs:The if statement uses an assignment statement as a condition, which is > confusing. > Signed-off-by: Liu Bin <liubin001@xxxxxxxxxx> What's the point? I prefer the style you change it to as well, but there is no real downside, and changing code just for the sake of it causes nothing but churn.