On Sun, Jul 09, 2023 at 03:37:50PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
>
> Remove this test, not sure why it was committed...
>
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
> tests/xfs/999 | 66 -----------------------------------------------------
> tests/xfs/999.out | 15 ------------
> 2 files changed, 81 deletions(-)
> delete mode 100755 tests/xfs/999
> delete mode 100644 tests/xfs/999.out
Thanks for spotting it. I'm quite sure this was a result of my initial attempts
of using b4 to retrieve the xfsprogs patch from the list, and it ended up
retrieving the whole thread which included xfstests patches.
Won't happen again, thanks for the heads up.
Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
--
Carlos
>
> diff --git a/tests/xfs/999 b/tests/xfs/999
> deleted file mode 100755
> index 9e799f66e72..00000000000
> --- a/tests/xfs/999
> +++ /dev/null
> @@ -1,66 +0,0 @@
> -#! /bin/bash
> -# SPDX-License-Identifier: GPL-2.0
> -# Copyright (c) 2020 Red Hat, Inc. All Rights Reserved.
> -#
> -# FS QA Test 521
> -#
> -# Test xfs_repair's progress reporting
> -#
> -. ./common/preamble
> -_begin_fstest auto repair
> -
> -# Override the default cleanup function.
> -_cleanup()
> -{
> - cd /
> - rm -f $tmp.*
> - _cleanup_delay > /dev/null 2>&1
> -}
> -
> -# Import common functions.
> -. ./common/filter
> -. ./common/dmdelay
> -. ./common/populate
> -
> -# real QA test starts here
> -
> -# Modify as appropriate.
> -_supported_fs xfs
> -_require_scratch
> -_require_dm_target delay
> -
> -# Filter output specific to the formatters in xfs_repair/progress.c
> -# Ideally we'd like to see hits on anything that matches
> -# awk '/{FMT/' xfsprogs-dev/repair/progress.c
> -filter_repair()
> -{
> - sed -nre '
> - s/[0-9]+/#/g;
> - s/^\s+/ /g;
> - s/(# (week|day|hour|minute|second)s?(, )?)+/{progres}/g;
> - /#:#:#:/p
> - '
> -}
> -
> -echo "Format and populate"
> -_scratch_populate_cached nofill > $seqres.full 2>&1
> -
> -echo "Introduce a dmdelay"
> -_init_delay
> -DELAY_MS=38
> -
> -# Introduce a read I/O delay
> -# The default in common/dmdelay is a bit too agressive
> -BLK_DEV_SIZE=`blockdev --getsz $SCRATCH_DEV`
> -DELAY_TABLE_RDELAY="0 $BLK_DEV_SIZE delay $SCRATCH_DEV 0 $DELAY_MS"
> -_load_delay_table $DELAY_READ
> -
> -echo "Run repair"
> -SCRATCH_DEV=$DELAY_DEV _scratch_xfs_repair -o ag_stride=4 -t 1 2>&1 |
> - tee -a $seqres.full > $tmp.repair
> -
> -cat $tmp.repair | filter_repair | sort -u
> -
> -# success, all done
> -status=0
> -exit
> diff --git a/tests/xfs/999.out b/tests/xfs/999.out
> deleted file mode 100644
> index e27534d8de6..00000000000
> --- a/tests/xfs/999.out
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -QA output created by 999
> -Format and populate
> -Introduce a dmdelay
> -Run repair
> - - #:#:#: Phase #: #% done - estimated remaining time {progres}
> - - #:#:#: Phase #: elapsed time {progres} - processed # inodes per minute
> - - #:#:#: check for inodes claiming duplicate blocks - # of # inodes done
> - - #:#:#: process known inodes and inode discovery - # of # inodes done
> - - #:#:#: process newly discovered inodes - # of # allocation groups done
> - - #:#:#: rebuild AG headers and trees - # of # allocation groups done
> - - #:#:#: scanning agi unlinked lists - # of # allocation groups done
> - - #:#:#: scanning filesystem freespace - # of # allocation groups done
> - - #:#:#: setting up duplicate extent list - # of # allocation groups done
> - - #:#:#: verify and correct link counts - # of # allocation groups done
> - - #:#:#: zeroing log - # of # blocks done
