Re: [PATCH 2/5] xfs/569: skip post-test fsck run

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2023-07-03 10:03:44, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
> 
> This test examines the behavior of mkfs.xfs with specific filesystem
> configuration files by formatting the scratch device directly with those
> exact parameters.  IOWs, it doesn't include external log devices or
> realtime devices.  If external devices are set up, the post-test fsck
> run fails because the filesystem doesnt' use the (allegedly) configured
> external devices.  Fix that by adding _require_scratch_nocheck.
> 
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
>  tests/xfs/569 |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/tests/xfs/569 b/tests/xfs/569
> index e8902708bc..b6d5798058 100755
> --- a/tests/xfs/569
> +++ b/tests/xfs/569
> @@ -14,7 +14,7 @@ _begin_fstest mkfs
>  
>  # Modify as appropriate.
>  _supported_fs xfs
> -_require_scratch
> +_require_scratch_nocheck
>  
>  ls /usr/share/xfsprogs/mkfs/*.conf &>/dev/null || \
>  	_notrun "No mkfs.xfs config files installed"
> 

Looks good to me:
Reviewed-by: Andrey Albershteyn <aalbersh@xxxxxxxxxx>

-- 
- Andrey




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux