On Tue, Jun 27, 2023 at 06:03:25PM +0800, Lu Hongfei wrote: > loff_t start_byte; > loff_t end_byte; > - int blocksize = i_blocksize(inode); > + unsigned int blocksize = i_blocksize(inode); Please keep the existing alignment of the variable names. With that the patch looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>