On Wed 21-06-23 07:52:27, Christoph Hellwig wrote: > On Wed, Jun 21, 2023 at 04:47:42PM +0200, Jan Kara wrote: > > ext4_bdev_mark_dead() passes bdev->bd_holder to ext4_force_shutdown() > > instead of bdev->bd_super leading to crashes. Fix it. > > How does this crash? ext4_blkdev_get passes the sb as holder, and I > actually tested this code. > > This is not to be confused with the blkdev_get_by_path in get_tree_bdev, > but that never ends up in ext4_bdev_mark_dead. Indeed, I have confused the method called for journal device with the method called for the main filesystem device. Both my patches are wrong and I'm sorry for the confusion! Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
