On Fri, Jun 16, 2023 at 11:59:06AM +1000, Dave Chinner wrote: > + if (!(XFS_AGF_GOOD_VERSION(be32_to_cpu(agf->agf_versionnum)))) This has a superflous set of braces that can be dropped. > + /* > + * during growfs operations, the perag is not fully initialised, Missing captialization for the first word. (And yes I noticed this just moved, but we might as well fix it up while at it). Otherwise this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>