On Mon, Jun 12, 2023 at 08:05:20AM -0700, Darrick J. Wong wrote: > static inline struct iomap_folio_state * > to_folio_state(struct folio *folio) > { > return folio->private; > } I'd reformat it to not-XFS-style: static inline struct iomap_folio_state *to_folio_state(struct folio *folio) { return folio->private; } But other than that, I approve. Unless you just want to do without it entirely and do struct iomap_folio_state *state = folio->private; instead of struct iomap_folio_state *state = to_folio_state(folio); I'm having a hard time caring between the two.