Pankaj Raghav <p.raghav@xxxxxxxxxxx> writes:
> Minor nit:
>
>> +static int iomap_write_delalloc_punch(struct inode *inode, struct folio *folio,
>> + loff_t *punch_start_byte, loff_t start_byte, loff_t end_byte,
>> + int (*punch)(struct inode *inode, loff_t offset, loff_t length))
>> +{
>> + int ret = 0;
>> +
>> + if (!folio_test_dirty(folio))
>> + return ret;
> Either this could be changed to `goto out`
>
> OR
>
>> +
>> + /* if dirty, punch up to offset */
>> + if (start_byte > *punch_start_byte) {
>> + ret = punch(inode, *punch_start_byte,
>> + start_byte - *punch_start_byte);
>> + if (ret)
>> + goto out;
>
> This could be changed to `return ret` and we could get rid of the `out`
> label.
Sure, thanks Pankaj. I noted that too.
Since there is nothing in the out label. So mostly will simply return
ret. Will fix it in the next rev.
-ritesh
