Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: > On Sat, Jun 10, 2023 at 05:09:05PM +0530, Ritesh Harjani (IBM) wrote: >> This patch factors iomap_write_delalloc_punch() function out. This function >> is resposible for actual punch out operation. >> The reason for doing this is, to avoid deep indentation when we bring punch-out >> of individual non-dirty blocks within a dirty folio in a later patch >> (which adds per-block dirty status handling to iomap) to avoid delalloc block >> leak. > > A bunch of overly long lines in the commit message here, > but otherwise this looks good: Sure. Will shorten those in next revision (considering we might need it for some minor changes in patch-6) > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! -ritesh