On Wed, Jun 07, 2023 at 10:33:52PM -0700, Christoph Hellwig wrote: > On Wed, Jun 07, 2023 at 09:07:19PM +0530, Ritesh Harjani wrote: > > I think the only remaining piece is the naming of this enum and struct > > iomap_page. > > > > Ok, so here is what I think my preference would be - > > > > This enum perfectly qualifies for "iomap_block_state" as it holds the > > state of per-block. > > Then the struct iomap_page (iop) should be renamed to struct > > "iomap_folio_state" (ifs), because that holds the state information of all the > > blocks within a folio. > > Fine with me. Yeah, fine with me too. > > > if (!iof) > > > return NULL; > > > > > > here and unindent the rest. > > > > Sure. Is it ok to fold this change in the same patch, right? > > Or does it qualify for a seperate patch? > > Either way is fine with me. Same patch is ok. --D
