On 2023-06-06 15:29:14, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > This test deliberate crashes xfs_repair midway through writing metadata > to check that NEEDSREPAIR is always triggered by filesystem writes. > However, the subsequent scan for the NEEDSREPAIR feature bit prints > verifier errors to stderr. > > On a filesystem with metadata directories, this leads to the test > failing with this recorded in the golden output: > > +Metadata CRC error detected at 0x55c0a2dd0d38, xfs_dir3_block block 0xc0/0x1000 > +dir block owner 0x82 doesnt match block 0xbb8cd37e44eb3623 > > This isn't specific to metadata directories -- any repair crash could > leave a metadata structure in a weird state such that starting xfs_db > will spray verifier errors. For _check_scratch_xfs_features here, we > don't care if the filesystem is corrupt; we /only/ care that the > superblock feature bit is set. Route all that noise to devnull. > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > --- Looks good to me. Reviewed-by: Andrey Albershteyn <aalbersh@xxxxxxxxxx>
