Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: > On Tue, Jun 06, 2023 at 05:13:50PM +0530, Ritesh Harjani (IBM) wrote: >> This patch moves iomap_write_delalloc_punch() out of >> iomap_write_delalloc_scan(). No functionality change in this patch. > > Please chose one refactor (the existing function), or factor (the > new function) out. The mix doesn't make much sense. > > Also please explain why you're doing that. The fact tha a new helper > is split out is pretty obvious from the patch, but I have no idea why > you want it. This patch factors iomap_write_delalloc_punch() function out. This function is resposible for actual punch out operation. The reason for this is, to avoid deep indentation when we bring punch-out of individual non-dirty blocks within a dirty folio in a later patch to avoid delalloc block leak. This later patch is what adds per-block dirty status handling to iomap. I will rephrase commit message to above ^^^. Let me know if any other changes requried. -ritesh
