Re: [PATCH V2] xfs: Comment out unreachable code within xchk_fscounters()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 06, 2023 at 11:39:04PM -0700, Christoph Hellwig wrote:
> On Tue, Jun 06, 2023 at 05:11:22PM +0200, cem@xxxxxxxxxx wrote:
> > From: Carlos Maiolino <cem@xxxxxxxxxx>
> >
> > Comment the code out so kernel test robot stop complaining about it
> > every single test build.
> 
> Err, what?  #if 0ing commit coe is a complete no-go.  If this code
> is dead it should be removed.

The code isn't dead, it's temporarily broken. I spoke with Darrick about
removing it, but by doing that, later, 'reverting' the patch that removed the
broken code, will break the git history (specifically for git blame), and I
didn't want to give Darrick extra work by needing to re-add back all this code
later when he come back to work on this.
Anyway, just an attempt to quiet built test warning alerts :)
I'm totally fine ^R'ing these emails :)

-- 
Carlos



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux