On Mon, Jun 05, 2023 at 08:37:56AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
>
> Always log when we're junking a dirent from a non-shortform directory,
> because we're fixing corruptions. Even if we're in !verbose repair
> mode. Otherwise, we print things like:
>
> entry "FOO" in dir inode XXX inconsistent with .. value (YYY) in ino ZZZ
>
> Without telling the user that we're clearing the entry.
>
> Fixes: 6c39a3cbda3 ("Don't trash lost+found in phase 4 Merge of master-melb:xfs-cmds:29144a by kenmcd.")
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
> repair/phase6.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
>
>
> diff --git a/repair/phase6.c b/repair/phase6.c
> index a457429b3c6..3870c5c933a 100644
> --- a/repair/phase6.c
> +++ b/repair/phase6.c
> @@ -1883,8 +1883,7 @@ _("entry \"%s\" in dir inode %" PRIu64 " inconsistent with .. value (%" PRIu64 "
> dir_hash_junkit(hashtab, addr);
> dep->name[0] = '/';
> libxfs_dir2_data_log_entry(&da, bp, dep);
> - if (verbose)
> - do_warn(
> + do_warn(
> _("\twill clear entry \"%s\"\n"),
> fname);
> } else {
>
