[PATCHSET 0/2] xfs_repair: fix missing corruption detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all,

As part of QAing the parent pointers patchset, I noticed a couple of bad
bugs in xfs_repair.  The first is our handling of directories containing
the same name more than once -- we flag that and store both names, but
then we rebuild the directory with both of the offending names!  So, fix
that.

The other problem I noticed is that if the inobt is broken, many inodes
end up in the uncertain list.  Those files will get added back to the
filesystem indexes without the attr forks being checked, which means
that any corruption in them will not be found or fixed.

If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.

This is an extraordinary way to destroy everything.  Enjoy!
Comments and questions are, as always, welcome.

--D

xfsprogs git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=repair-fix-da-breakage
---
 repair/dino_chunks.c |    6 ++++--
 repair/phase6.c      |    3 ++-
 2 files changed, 6 insertions(+), 3 deletions(-)




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux