Re: [PATCH v2 0/5] block: simplify with PAGE_SECTORS_SHIFT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26.05.23 09:33, Luis Chamberlain wrote:
> A bit of block drivers have their own incantations with
> PAGE_SHIFT - SECTOR_SHIFT. Just simplfy and use PAGE_SECTORS_SHIFT
> all over.
>                                                                                                                                                                                               
> Based on linux-next next-20230525.
> 
> Changes since v1:
> 
>  o keep iomap math visibly simple
>  o Add tags for Reviews/acks
>  o rebase onto next-20230525
> 
> Luis Chamberlain (5):
>   block: annotate bdev_disk_changed() deprecation with a symbol
>     namespace
>   drbd: use PAGE_SECTORS_SHIFT and PAGE_SECTORS
>   iomap: simplify iomap_init() with PAGE_SECTORS
>   dm bufio: simplify by using PAGE_SECTORS_SHIFT
>   zram: use generic PAGE_SECTORS and PAGE_SECTORS_SHIFT
> 
>  block/partitions/core.c          |  6 +-----
>  drivers/block/drbd/drbd_bitmap.c |  4 ++--
>  drivers/block/loop.c             |  2 ++
>  drivers/block/zram/zram_drv.c    | 12 ++++++------
>  drivers/block/zram/zram_drv.h    |  2 --
>  drivers/md/dm-bufio.c            |  4 ++--
>  drivers/s390/block/dasd_genhd.c  |  2 ++
>  fs/iomap/buffered-io.c           |  2 +-
>  8 files changed, 16 insertions(+), 18 deletions(-)
> 

Hey Luis,
I've found another one in sd_zbc_revalidate_zones():

	max_append = min_t(u32, logical_to_sectors(sdkp->device, zone_blocks),
			   q->limits.max_segments << (PAGE_SHIFT - 9));

Mind taking care of it in the next round as well?

Thanks,
	Johannes




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux