On Tue, May 23, 2023 at 10:13:42 AM -0700, Darrick J. Wong wrote: > On Tue, May 23, 2023 at 02:30:33PM +0530, Chandan Babu R wrote: >> A future commit will require that the metadump file be opened before execution >> of init_metadump(). > > Why is that? > The metadump v2 initialization function (i.e. init_metadump_v2()) writes the header structure (i.e. struct xfs_metadump_header) into the metadump file. This will require the program to open the metadump file before initialization function has been invoked. I will add the above to the commit description. -- chandan