Re: [PATCH 18/24] mdrestore: Introduce struct mdrestore_ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 23, 2023 at 10:44:49 AM -0700, Darrick J. Wong wrote:
> On Tue, May 23, 2023 at 02:30:44PM +0530, Chandan Babu R wrote:
>> We will need two sets of functions to work with two versions of metadump
>> formats. This commit adds the definition for 'struct mdrestore_ops' to hold
>> pointers to version specific mdrestore functions.
>> 
>> Signed-off-by: Chandan Babu R <chandan.babu@xxxxxxxxxx>
>
> Looks ok, though I think those three int fields are really bool, right?
>

Yes, you are right. I will change the data type of these variables.

> Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
>

-- 
chandan



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux