On Tue, May 23, 2023 at 09:35:14 AM -0700, Darrick J. Wong wrote: > On Tue, May 23, 2023 at 02:30:29PM +0530, Chandan Babu R wrote: >> This commit collects all state tracking variables in a new "struct metadump" >> structure. > > I think this commit message needs to capture the reasons for /why/ all > these global variables are being pulled into a struct definition that > itself is used once to define a global variable. > The purpose of moving the global variables into one structure was to collect them in one place in the code rather than having them spread across the file. A new member of type "struct metadump_ops *" will be added by a future commit to support the two versions of metadump. I will add the above as part of the commit description. -- chandan
